Handle python BoolOp for multiple arguments #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximiliankaul
previously requested changes
Sep 20, 2024
...anguage-python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/ExpressionHandler.kt
Outdated
Show resolved
Hide resolved
oxisto
reviewed
Sep 20, 2024
...age-python/src/test/kotlin/de/fraunhofer/aisec/cpg/frontends/python/ExpressionHandlerTest.kt
Outdated
Show resolved
Hide resolved
...age-python/src/test/kotlin/de/fraunhofer/aisec/cpg/frontends/python/ExpressionHandlerTest.kt
Outdated
Show resolved
Hide resolved
...age-python/src/test/kotlin/de/fraunhofer/aisec/cpg/frontends/python/ExpressionHandlerTest.kt
Outdated
Show resolved
Hide resolved
...age-python/src/test/kotlin/de/fraunhofer/aisec/cpg/frontends/python/ExpressionHandlerTest.kt
Outdated
Show resolved
Hide resolved
...age-python/src/test/kotlin/de/fraunhofer/aisec/cpg/frontends/python/ExpressionHandlerTest.kt
Outdated
Show resolved
Hide resolved
...age-python/src/test/kotlin/de/fraunhofer/aisec/cpg/frontends/python/ExpressionHandlerTest.kt
Outdated
Show resolved
Hide resolved
oxisto
approved these changes
Sep 20, 2024
oxisto
approved these changes
Sep 23, 2024
oxisto
force-pushed
the
ak/pythonBoolOp
branch
from
89b473d
to
4df43fb
Compare
Should be ok since we create the binary operators correctly. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to support python
BoolOps for more than 2 values. It also adds some tests to determine if the EOG makes sense for BoolOps with different operators (andandor).To the reviewer(s): Please check if the EOG checks actually make sense!
Fixes #1699